rjmccall added inline comments.
================ Comment at: include/clang/Basic/FixedPoint.h:31 + SatNoPadding, +}; + ---------------- I figured you'd want this to be a struct which include the scale, width, signed-ness, and saturating-ness; and then `APFixedPoint` can just store one of these next to a bare `APInt`. ================ Comment at: include/clang/Basic/FixedPoint.h:41 + APFixedPoint(const llvm::APSInt &Val, unsigned Scale, + enum FixedPointSemantics Sema) + : Val(Val), Scale(Scale), Sema(Sema) {} ---------------- Why the elaborated-type-specifier? Repository: rC Clang https://reviews.llvm.org/D48661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits