ldionne added inline comments.
================
Comment at: include/string:836
_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
- basic_string(const _Tp& __t, size_type __pos, size_type __n,
- const allocator_type& __a = allocator_type(),
- typename
enable_if<__can_be_converted_to_string_view<_CharT, _Traits, _Tp>::value,
void>::type* = 0);
- _LIBCPP_INLINE_VISIBILITY explicit
- basic_string(__self_view __sv);
- _LIBCPP_INLINE_VISIBILITY
- basic_string(__self_view __sv, const _Allocator& __a);
+ explicit basic_string(const _Tp& __t, size_type __pos, size_type __n,
+ const allocator_type& __a = allocator_type());
----------------
I believe an unwelcome `explicit` snuck in here.
================
Comment at: include/string:839
+
+// template<class _Tp>
+// _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
----------------
Did you mean to leave those comments there?
================
Comment at: include/string:856
+ _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
+ explicit basic_string(const _Tp& __t, const allocator_type& __a);
+
----------------
I think this `explicit` shouldn't be there, too.
https://reviews.llvm.org/D48616
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
