NoQ marked 2 inline comments as done.
NoQ added inline comments.
================
Comment at: lib/Analysis/CFG.cpp:799
+ ConstructionContextMap.lookup(ME)) {
+ cleanupConstructionContext(ME);
+ if (const auto *CC = ConstructionContext::createFromLayers(
----------------
george.karpenkov wrote:
> Do we want to cleanup construction context here even if the condition below
> is not met?
Yeah, most certainly. Failure to create construction context from existing
layers indicates that we've encountered a valid set of layers that's currently
not supported. We still need to inform the rest of the builder that these
layers were taken into account rather than leaked.
https://reviews.llvm.org/D48608
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
