george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land.
LGTM provided the nit on passing arguments is fixed. ================ Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:696 void ento::registerUninitializedObjectChecker(CheckerManager &Mgr) { auto Chk = Mgr.registerChecker<UninitializedObjectChecker>(); Chk->IsPedantic = Mgr.getAnalyzerOptions().getBooleanOption( ---------------- registerChecker passes through arguments to the constructor. Could we use that instead of mutable fields? Repository: rC Clang https://reviews.llvm.org/D48285 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits