sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/GlobalCompilationDatabase.cpp:137 + // 'It' may be invalid at this point, recompute it. + It = Cached.find(File); + if (It != Cached.end()) ---------------- `return try_emplace(File, std::move(Command)).second`? (This has different behavior if the cache was filled while you unlocked, but it's arguably the right behavior and doesn't really matter). ================ Comment at: clangd/GlobalCompilationDatabase.h:93 +public: + explicit CachingCompilationDb(GlobalCompilationDatabase &InnerCDB); + ---------------- const ref Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48068 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
