NoQ added inline comments.

================
Comment at: lib/Analysis/CFG.cpp:1320
+        auto *MTE = cast<MaterializeTemporaryExpr>(Child);
+        findConstructionContexts(ConstructionContextLayer::create(
+                                     cfg->getBumpVectorContext(), MTE, Layer),
----------------
NoQ wrote:
> george.karpenkov wrote:
> > There are three repeated calls to `findConstructionContexts`, with only the 
> > second argument changing. Perhaps a helper lambda closure would help?
> I'll look into this later for the whole function.
Aha, we are changing the whole function anyway, ok then.


https://reviews.llvm.org/D47616



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to