george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: dmgreen.


================
Comment at: lib/Analysis/CFG.cpp:1348
+    for (auto &Parent : ASTCtx.getParents(Node)) {
+      NodesToVisit.push(Parent);
+    }
----------------
shouldn't we have a `visited` list as well, to avoid exponential queue 
explosion if nodes are repeated?


https://reviews.llvm.org/D39398



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to