benhamilton edited reviewers, added: klimek; removed: djasper.
benhamilton added a comment.
@djasper isn't available to review.
At a high level, this seems good, but I'd like @klimek to take a look.
================
Comment at: lib/Format/UnwrappedLineParser.cpp:1320
+// \endcode
+bool UnwrappedLineParser::tryToParseBlock() {
+ // Consume the leading ^.
----------------
Is it standard to return a value from these `tryToParseFoo()` methods, even if
nobody uses it?
I think we should either check the return value somewhere, or make this return
`void`.
================
Comment at: lib/Format/UnwrappedLineParser.cpp:1324-1327
+ if (!Style.isCpp()) {
+ // Blocks are only supported in C++ and Objective-C.
+ return false;
+ }
----------------
Style: Remove curly braces for one-line if blocks.
https://reviews.llvm.org/D40221
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
