erichkeane added inline comments.
================ Comment at: lib/Tooling/CompilationDatabase.cpp:303 + // Remove temp files. + Compilation->CleanupFileList(Compilation->getTempFiles()); + ---------------- It seems to me that this would be best called from the destructor of the Compilation object. I realize nothing returns before this, but IMO this seems universal enough that if it doesn't break anything, putting this in the destructor would be a proper place for cleanup. Repository: rC Clang https://reviews.llvm.org/D45686 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
