[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

[Mark Searles via Phabricator via cfe-commits]

msearles updated this revision to Diff 147807.
msearles retitled this revision from "[Clang Tablegen] Add default case to 
getModifierName()" to "[Clang Tablegen]  Add llvm_unreachable() to 
getModifierName()".
msearles added a comment.

Ah, yes. Adding llvm_unreachable() is better. Done.


https://reviews.llvm.org/D47150

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===================================================================
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,7 @@
   case MT_Unknown:
     llvm_unreachable("invalid modifier type");
   }
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {



Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===================================================================
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,7 @@
   case MT_Unknown:
     llvm_unreachable("invalid modifier type");
   }
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits