a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.

Hi Gabor! I have a question.



================
Comment at: lib/AST/ASTImporter.cpp:4305
+    // Add to the DC only if it was an explicit specialization/instantiation.
+    if (D2->getTemplateSpecializationKind() != TSK_ImplicitInstantiation) {
+      LexicalDC->addDeclInternal(D2);
----------------
Can we write `if (D2->isExplicitInstantiationOrSpecialization())` instead? How 
we should treat TSK_Undeclared case?


Repository:
  rC Clang

https://reviews.llvm.org/D47058



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to