a.sidorin added a comment. Hello Rafael,
The patch is awesome. The only thing I'm uncomfortable with is that we call invalidation on every stmt import - not only during the top-level one. Fixing this requires separating entry point from internal imports and is out of scope of this patch, but adding some FIXMEs is very appreciated. ================ Comment at: lib/AST/ASTImporter.cpp:6755 + auto ToE = cast_or_null<Expr>(Import(cast<Stmt>(FromE))); + if (ToE) + ToContext.invalidateParents(); ---------------- We already do the invalidation in Import(Stmt), so it looks redundant here. Repository: rC Clang https://reviews.llvm.org/D46940 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
