zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.


================
Comment at: modernize/UseAutoCheck.cpp:40
+            ? Alpha
+            : (std::isspace(C) || (!RemoveStars && C == '*')) ? Space
+                                                              : Punctuation;
----------------
rsmith wrote:
> `isspace` here is wrong: it's a locale-sensitive check. Clang assumes UTF-8 
> throughout; you can use `isWhitespace` from clang/Basic/CharInfo.h to test if 
> the character should be treated as whitespace.
Thanks!


https://reviews.llvm.org/D45927



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D45927: [clang... Zinovy Nis via Phabricator via cfe-commits

Reply via email to