alexfh added a comment. In https://reviews.llvm.org/D45931#1087007, @lebedev.ri wrote:
> In https://reviews.llvm.org/D45931#1086665, @alexfh wrote: > > > In https://reviews.llvm.org/D45931#1084503, @lebedev.ri wrote: > > > > > In https://reviews.llvm.org/D45931#1083192, @lebedev.ri wrote: > > > > > > > Thank you for looking at this. > > > > > > > > In https://reviews.llvm.org/D45931#1083184, @alexfh wrote: > > > > > > > > > From a user's perspective I'd probably prefer a different behavior of > > > > > checks profiling with multiple translation units: per-file table > > > > > after each file and an aggregate table at the end. > > > > > > > > > > > > Is this a review note, or a general observation? > > > > > > > > > Why not both? ;) > > > BTW, that did not answer the question: > > > I'm sure it could be done, i'm just not too sure how useful it would be, > > since it seems no one before now even noticed that timing with multiple > > TU's was 'broken'. I think, I noticed incorrect handling of profiling with multiple TUs at some point and switched to running clang-tidy multiple times. The solution I proposed (most importantly, point 1) would be the most convenient one for me at that time: > I'd probably go with a set of features enough for various use cases: > > 0. don't add any profile merging logic to clang-tidy > > 1. dump profile after each TU to the screen in the current tabulated format > 2. add a flag to specify a file name prefix to dump profile output for each > file as CSV > 3. (optional) add a script to merge profiles from CSV files and dump as CSV > or tabulated (without a script this could be done in a spreadsheet) Are any other questions still open? Repository: rC Clang https://reviews.llvm.org/D45931 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
