alexfh added inline comments.

================
Comment at: clang-tidy/google/IntegerTypesCheck.cpp:66
+  Finder->addMatcher(typeLoc(loc(isInteger()),
+                             unless(hasAncestor(callExpr(
+                                 
callee(functionDecl(hasAttr(attr::Format)))))))
----------------
I vaguely remember that there were some problems matching ancestors of 
TypeLocs. I hope this has been solved since then, but making a test more robust 
would be useful. See the other comment.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46293



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to