lebedev.ri added inline comments.
================
Comment at: clang-doc/BitcodeWriter.cpp:275
+static SymbolID SID;
void ClangDocBitcodeWriter::emitRecord(const SymbolID &Sym, RecordId ID) {
----------------
1. I'm not seeing where this is being changed?
2. This looks like some abstraction is missing. Maybe at least put it as
private member of `ClangDocBitcodeWriter`?
================
Comment at: clang-doc/BitcodeWriter.h:34
// BitCodeConstants, though they can be added without breaking it.
static const unsigned VersionNumber = 1;
----------------
Looking at the changes, may want to bump the version.
================
Comment at: clang-doc/BitcodeWriter.h:64
BI_FIRST = BI_VERSION_BLOCK_ID,
- BI_LAST = BI_COMMENT_BLOCK_ID
+ BI_LAST = BI_REFERENCE_BLOCK_ID
};
----------------
General observation: you could keep `BI_LAST` element as the last one in the
enum (just like the rest,
without specifying it's value), and use it just like the `end()`, i.e. `v <
BI_LAST` instead of `v <= BI_LAST`.
https://reviews.llvm.org/D46281
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
