aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a few small nits. ================ Comment at: include/clang/Basic/IdentifierTable.h:471 + /// \brief Create the identifier table. + IdentifierTable(IdentifierInfoLookup *externalLookup = nullptr); + ---------------- `ExternalLookup` to match coding conventions. Also, can you mark this constructor as explicit? Might as well change the other constructor as well since it's being reformatted. Repository: rC Clang https://reviews.llvm.org/D35181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
