EricWF added inline comments.
================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9384-9385
+def err_spaceship_comparison_of_void_ptr : Error<
+ "three-way comparison with void pointer %select{operand type|operand types}0
"
+ "(%1 and %2)">;
+def err_spaceship_comparison_of_invalid_comp_type : Error<
----------------
rsmith wrote:
> EricWF wrote:
> > rsmith wrote:
> > > Why are you diagnosing this case as an error?
> > [expr.spaceship]p9 seems to require it. The composite pointer type is not a
> > function/member/null pointer type, neither is it a object pointer type, so
> > the program is ill-formed.
> >
> > Unless I'm missing something.
> void* is an object pointer type.
Oh. right. 'object pointer' vs 'pointer-to-object'.
https://reviews.llvm.org/D45476
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
