aaron.ballman added a comment.

Can you rebase the patch? The patch did not apply cleanly for me against trunk 
(the contents of the check function are appearing in 
`CheckARMBuiltinExclusiveCall()`).

(Also, one tiny nit about escaped characters that can be fixed at the same 
time.)



================
Comment at: lib/Sema/SemaChecking.cpp:1133
+      Diag(FnPtrArg->getLocStart(), diag::err_typecheck_convert_incompatible)
+          << FnPtrArgType << "\'int (*)(const char *, ...)\'" << 1 << 0 << 3
+          << 2 << FnPtrArgType << "\'int (*)(const char *, ...)\'";
----------------
Minor nit: can you remove the escape character for the single quotes (here and 
elsewhere in the patch), as there's no need to escape that character?


Repository:
  rC Clang

https://reviews.llvm.org/D44093



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to