JonasToth added inline comments.
================
Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92
+ if (N.getNodeAs<NamedDecl>("std_type"))
+ diag(Location, "shifting a value of the standardized bitmask types");
+ else
----------------
aaron.ballman wrote:
> How about: "shifting a value of bitmask type"
Not sure about that.
The general bitmasks are covered by the second `diag`.
This one should only trigger if a shift with the standardized bitmask types
occurs. This exception is necessary because those are allowed for the other
bitwise operations(&, |, ^), but i decided that shifting them makes no sense.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45414
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
