Eugene.Zelenko added a comment. In https://reviews.llvm.org/D45392#1060845, @Wizard wrote:
> In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote: > > > If this is Apple guideline, check name should reflect this. I think will be > > good idea to have general check for Apple naming conventions instead of > > separate checks for specific situations like //objc-ivar-declaration// and > > //objc-property-declaration//. > > > Thanks for the suggestion. I understand your point that they are both naming > convention, however, they are about different components and using totally > different naming rules. PropertyDeclarationCheck is already a very > complicated check (the most complicated one for ObjC), I would rather not > make it more heavy and try my best to split independent logic to different > checks. See readability-identifier-naming <http://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html> as example of multiple rules in one check. ================ Comment at: docs/ReleaseNotes.rst:60 +- New :doc:`objc-ivar-declaration + <clang-tidy/checks/objc-ivar-declaration>` check ---------------- Wizard wrote: > Eugene.Zelenko wrote: > > Please place in new check list in alphabetical order. > I did not see a "new check list" in alphabetical order in this file. I > believe they are ordered by commit time.If you mean the list.rst, they are > already ordered alphabetically. Please read starting words in list of changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
