Hahnfeld added inline comments.
================ Comment at: include/clang/Basic/Cuda.h:61 + GFX900, + GFX902, LAST, ---------------- rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > Does this actually have anything to do with HIP? You have a lot of > > > changes in this patch which seem to just be about supporting more GPU > > > revisions. > > This patch not only adds support of HIP language mode but also adds support > > of amdgpu to CUDA toolchain. > > > > Currently HIP extension is only supported by amdgpu although in the future > > it may be supported by other targets. > I understand that, but I think you can separate those two patches without too > much difficulty. There already is D42800 with lots of unanswered comments, so those need to be addressed first. https://reviews.llvm.org/D45212 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
