fhahn added a reviewer: rengolin.
fhahn added a comment.
Thanks for looking into this Eli! Adding the architecture version as target
feature looks good to me.
================
Comment at: lib/Basic/Targets/ARM.cpp:342
+ // rely on the target triple.
+ switch (ArchKind) {
+ case llvm::ARM::ArchKind::INVALID:
----------------
Would it make sense to add this to llvm/Support/TargetParser? We already have
`AArch64::getArchFeatures` there and it looks like it does something similar
for AArch64.
llvm/Support/ARMTargetParser.def defines the different architectures +
extensions and it seems like it should possible to extend it slightly to handle
the architecture features.
Repository:
rC Clang
https://reviews.llvm.org/D45240
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
