mstorsjo added a comment.

In https://reviews.llvm.org/D45152#1056134, @rnk wrote:

> In https://reviews.llvm.org/D45152#1056122, @mstorsjo wrote:
>
> > In https://reviews.llvm.org/D45152#1055871, @rnk wrote:
> >
> > > Seems reasonable, looks good.
> >
> >
> > Any opinion on the wording of the option name?
>
>
> Maybe what we're trying to do is find the sysroot relative to clang, so an 
> option name phrased along those lines makes more sense? 
> --clang-in-sysroot-bin? --from-sysroot-bin? --assume-sysroot-bin? 
> --in-sysroot-bin?


That sounds sensible - and positive options is often better than negated/ignore 
etc. I think I prefer `--assume-sysroot-bin` out of those.


Repository:
  rC Clang

https://reviews.llvm.org/D45152



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to