george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land.
LGTM provided comments are answered. Field rename would be appreciated, if possible. ================ Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:215 + // able to find construction context at all. + CallOpts.IsCtorOrDtorWithImproperlyModeledTargetRegion = true; + } else if (!isa<TemporaryObjectConstructionContext>( ---------------- Is this field `false` by default? Also, double negation is harder to read (e.g. `not modelled properly = false` vs. `modelled property = true`), but I guess that should have been said earlier. https://reviews.llvm.org/D44854 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
