chenwj requested changes to this revision.
chenwj added a comment.
This revision now requires changes to proceed.
Nits.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3644
+void CGDebugInfo::EmitLabel(const LabelDecl *D,
+ CGBuilderTy &Builder) {
+ assert(DebugKind >= codegenoptions::LimitedDebugInfo);
----------------
Indent.
================
Comment at: lib/CodeGen/CGStmt.cpp:535
+
+ // Emit debug info for label.
+ if (HaveInsertPoint())
----------------
I assume you emit debug info for the label only if it's reachable by checking
`HaveInsertPoint()`. If so, make the comment as
```
// Emit debug info for the label only if it's reachable.
```
I prefer adding braces here. Please check indent as well.
Repository:
rC Clang
https://reviews.llvm.org/D45045
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
