Eugene.Zelenko added inline comments.
================ Comment at: clang-tidy/bugprone/ComparisonInTempFailureRetryCheck.cpp:51 +} +} + ---------------- Please add // namespace and remove one empty line below. ================ Comment at: docs/ReleaseNotes.rst:60 +- New `bugprone-comparison-in-temp-failure-retry + <http://clang.llvm.org/extra/clang-tidy/checks/bugprone-comparison-in-temp-failure-retry.html>`_ check ---------------- Please use alphabetical order in new checks list. Also rebase from trunk and use //:doc:// and adjust link. ================ Comment at: docs/clang-tidy/checks/bugprone-comparison-in-temp-failure-retry.rst:6 + +Checks whether a use of ``TEMP_FAILURE_RETRY`` has a top-level comparison in its +argument. Having such a use is incorrect in the vast majority of cases, and ---------------- Please make first statement same as in Release Notes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45059 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
