dschuff added inline comments.

================
Comment at: lib/CodeGen/CGException.cpp:1541
+  }
   llvm::CallInst *terminateCall =
+      CGM.getCXXABI().emitTerminateForUnexpectedException(*this, Exn);
----------------
aheejin wrote:
> dschuff wrote:
> > Should this be in an else block? No need to emit it after we emit the call 
> > to `__clang_call_terminate`
> I don't understand? The call emitted within the `if` block is not a call to 
> `__clang_call_terminate` but to `wasm.get.exception` intrinsic.
Oh you're right, I misread that, nevermind.


Repository:
  rC Clang

https://reviews.llvm.org/D44931



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to