simark marked 6 inline comments as done.
simark added inline comments.
Herald added a subscriber: MaskRay.
================
Comment at: unittests/clangd/DraftStoreTests.cpp:27
+
+static int rangeLength(StringRef Code, const Range &Rng) {
+ size_t Start = positionToOffset(Code, Rng.start);
----------------
ilya-biryukov wrote:
> ilya-biryukov wrote:
> > no need for `static`, since function is already inside an anonymous
> > namespace.
> > remove it?
> This comment is marked as done, but not addressed.
Hmm I addressed the comments at two different times, but I probably messed up
my branches or something, so I lost the changes of my first pass. Sorry about
that.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44272
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
