EricWF added inline comments.

================
Comment at: lib/Sema/SemaExprCXX.cpp:3458
+  }
+  TheCall->getCallee()->setType(OperatorNewOrDelete->getType());
+
----------------
rsmith wrote:
> It would be nice to assert that the callee you're setting the type of is an 
> ImplicitCastExpr doing a BuiltinFnToFnPtr cast (just so that it's obvious 
> that this is the only type we need to update and that it's freshly-created).
Ack. Done.


https://reviews.llvm.org/D43047



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D43047: [... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D430... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D430... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D430... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D430... Eric Fiselier via Phabricator via cfe-commits

Reply via email to