zinovy.nis added inline comments.
================
Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:127
+// Just to instantiate DF<F>.
+int bar() { return (new DF<int>())->virt_1(); }
----------------
aaron.ballman wrote:
> What should happen in this case?
> ```
> struct Base {
> virtual void f() {}
> };
>
> struct Intermediary : Base {
> };
>
> struct Derived : Intermediary {
> void f() override {
> Base::f(); // I would expect this not to diagnose
> }
> };
> ```
> This would be a reasonable test case to add.
Please see `// Test virtual method is diagnosted although not overridden in
parent.` section in the test file.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
