nathawes added a comment. In https://reviews.llvm.org/D39050#1037008, @malaperle wrote:
> In https://reviews.llvm.org/D39050#1036394, @nathawes wrote: > > > @malaperle Just to clarify, what's the particular end-loc we're talking > > about here? e.g. for a function call, would this be the end of the > > function's name, or the closing paren? > > For the end of the name, couldn't this be derived from the start loc + > > symbol name length (barring token pastes and escaped new lines in the > > middle of identifiers, which hopefully aren't too common)? > > I can see the value for the closing paren though. > > > I mean the end of the name referencing the symbol, so that it can be > highlighted properly when using the "find references in workspace" feature. > There are cases where the name of the symbol itself is not present, for > example "MyClass o1, o2;" (o1 and o2 reference the constructor), references > to overloaded operators, etc. Ah, I see – thanks! I was thinking all occurrences whose symbol name didn't actually appear at their location were marked with `SymbolRole::Implicit`, but that only seems to be true for the ObjC index data. https://reviews.llvm.org/D39050 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
