simark added inline comments.
================ Comment at: clangd/TUScheduler.h:69 + /// FIXME: remove the callback from this function + void updateCompileCommand(PathRef File, tooling::CompileCommand NewCommand, + IntrusiveRefCntPtr<vfs::FileSystem> FS, ---------------- sammccall wrote: > (summarizing offline discussion) > > this is so close to `update`, it'd be nice if we could just call `update` > instead. > > For that we need the contents, so forceReparse needs contents, so... can > forceReparse just be addDocument(skipCache=true) or something? > > Requiring content to be passed doesn't seem like a big burden in practice, > and makes it clear that clangdserver is never responsible for maintaining > copies of the content on the callers behalf (and clangdlspserver is). > > reparseOpenFiles needs to move to clangdlspserver, but this seems consistent > with the design. (so I think we can drop getTrackedFiles?) I also thought it would be nice to have only one method `update`. What about if the `Contents` member of `ParseInputs` is optional? When it is not instantiated (such as when calling `forceReparse`), it would mean to re-use the previously sent source. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44462 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
