gtbercea added inline comments.
================ Comment at: test/Driver/openmp-offload-gpu.c:150 +/// bitcode library and add it to the LIBRARY_PATH. +// RUN: touch %T/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \ ---------------- gtbercea wrote: > Hahnfeld wrote: > > grokos wrote: > > > ABataev wrote: > > > > Create empty `libomptarget-nvptx-sm_60.bc` in `Driver/lib` directory > > > > and use it in the test rather create|delete it dynamically. > > > I'm also in favour of this approach. On some systems /tmp is not > > > accessible and the regression test fails. > > This test doesn't (and shouldn't!) use `/tmp`. The build directory and `%T` > > are always writable (if not, you have different issues on your system). > > > > Btw you need to pay attention that the driver now finds files next to the > > compiler directory. You may want to make sure that the test always passes / > > doesn't fail for wrong reasons. > Just added this. @Hahnfeld I've used %S instead. The only way in which the test can be a false positive is when the lib folder contains this .bc file. But there's no way to stop this from happening since we check DefaultLibPath first. Repository: rC Clang https://reviews.llvm.org/D43197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
