Awesome, thanks! On Sun, Mar 4, 2018, 11:26 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman > Date: Sun Mar 4 08:24:10 2018 > New Revision: 326676 > > URL: http://llvm.org/viewvc/llvm-project?rev=326676&view=rev > Log: > Amend r326665 to print out the `used` attribute subjects in a different > order. > > Modified: > cfe/trunk/include/clang/Basic/Attr.td > cfe/trunk/test/Sema/attr-used.c > > Modified: cfe/trunk/include/clang/Basic/Attr.td > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=326676&r1=326675&r2=326676&view=diff > > ============================================================================== > --- cfe/trunk/include/clang/Basic/Attr.td (original) > +++ cfe/trunk/include/clang/Basic/Attr.td Sun Mar 4 08:24:10 2018 > @@ -2010,7 +2010,7 @@ def Unused : InheritableAttr { > > def Used : InheritableAttr { > let Spellings = [GCC<"used">]; > - let Subjects = SubjectList<[Function, ObjCMethod, NonLocalVar]>; > + let Subjects = SubjectList<[NonLocalVar, Function, ObjCMethod]>; > let Documentation = [Undocumented]; > } > > > Modified: cfe/trunk/test/Sema/attr-used.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/attr-used.c?rev=326676&r1=326675&r2=326676&view=diff > > ============================================================================== > --- cfe/trunk/test/Sema/attr-used.c (original) > +++ cfe/trunk/test/Sema/attr-used.c Sun Mar 4 08:24:10 2018 > @@ -3,7 +3,7 @@ > extern int l0 __attribute__((used)); // expected-warning {{'used' > attribute ignored}} > __private_extern__ int l1 __attribute__((used)); // expected-warning > {{'used' attribute ignored}} > > -struct __attribute__((used)) s { // expected-warning {{'used' attribute > only applies to functions, Objective-C methods, and variables with > non-local storage}} > +struct __attribute__((used)) s { // expected-warning {{'used' attribute > only applies to variables with non-local storage, functions, and > Objective-C methods}} > int x; > }; > > @@ -14,7 +14,7 @@ static void __attribute__((used)) f0(voi > > void f1() { > static int a __attribute__((used)); > - int b __attribute__((used)); // expected-warning {{'used' attribute > only applies to functions, Objective-C methods, and variables with > non-local storage}} > + int b __attribute__((used)); // expected-warning {{'used' attribute > only applies to variables with non-local storage, functions, and > Objective-C methods}} > } > > static void __attribute__((used)) f0(void); > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits