juliehockett added inline comments.

================
Comment at: clang-doc/Representation.h:117
+  bool IsDefinition = false;
+  llvm::Optional<Location> DefLoc;
+  llvm::SmallVector<Location, 2> Loc;
----------------
lebedev.ri wrote:
> I meant that `IsDefinition` controls whether `DefLoc` will be set/used or not.
> So with `llvm::Optional<Location> DefLoc`, you don't need the `bool 
> IsDefinition`.
That...makes so much sense. Oops. Thank you!


https://reviews.llvm.org/D41102



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to