v.g.vassilev added inline comments.
================
Comment at: lib/AST/ODRHash.cpp:581
+ void VisitType(const Type *T) {
+ ID.AddInteger(T->getTypeClass());
+ }
----------------
rtrieu wrote:
> rsmith wrote:
> > This looks redundant, the above `Visit(const Type*)` function seems to
> > already do this.
> That's correct, VisitType is intended to be empty. The TypeClass enum value
> is added in Visit so that it is the first value added to the data stream.
Ok, then I am a little confused. If `VisitType` is supposed to be nop why we
call it in all VisitXXX functions.
Repository:
rC Clang
https://reviews.llvm.org/D43696
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
