Hahnfeld added a comment.
Looking more closely at the patch, this doesn't seem to look into the `lib` /
`lib64` next to the compiler. I'm not sure if `LIBRARY_PATH` is set for every
installation, so I think we should add this one to catch the obvious case. This
probably needs some attention for the tests because they'll find the just-built
libraries...
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+ std::pair<StringRef, StringRef> Split =
+ CompilerPath.split(llvm::sys::EnvPathSeparator);
+ LibraryPaths.push_back(Split.first);
+ CompilerPath = Split.second;
+ }
----------------
`tools::addDirectoryList` uses `StringRef::find`, I'm not sure if
`StringRef::split` creates real copies of the string...
Repository:
rC Clang
https://reviews.llvm.org/D43197
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
