oren_ben_simhon marked 6 inline comments as done.
oren_ben_simhon added inline comments.
================
Comment at: include/clang/Basic/Attr.td:2089
+def AnyX86NoCfCheck : InheritableAttr, TargetSpecificAttr<TargetAnyX86>{
+ let Spellings = [GCC<"nocf_check">];
+ let Documentation = [AnyX86NoCfCheckDocs];
----------------
aaron.ballman wrote:
> This attribute doesn't appear to be supported by GCC. Did you mean to use the
> Clang spelling instead?
Attribute documentation can be found here:
https://gcc.gnu.org/onlinedocs/gcc/x86-Function-Attributes.html#x86-Function-Attributes
================
Comment at: lib/Sema/SemaDeclAttr.cpp:2007
+
+bool Sema::CheckAttrNoArgs(const AttributeList &Attr) {
+ if (!checkAttributeNumArgs(*this, Attr, 0)) {
----------------
craig.topper wrote:
> Wy did this get renamed?
To reuse existing code. The same check is performed in several attributes so
instead of writing this block for every attribute i only call this function.
================
Comment at: lib/Sema/SemaDeclAttr.cpp:2016
-bool Sema::CheckNoCallerSavedRegsAttr(const AttributeList &Attr) {
+bool Sema::CheckAttrTarget(const AttributeList &Attr) {
// Check whether the attribute is valid on the current target.
----------------
craig.topper wrote:
> Why did this get renamed?
To remove multiple code fragments. Same as CheckAttrNoArgs.
Repository:
rL LLVM
https://reviews.llvm.org/D41880
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
