ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: unittests/clangd/ClangdTests.cpp:783 public: - NoConcurrentAccessDiagConsumer(std::promise<void> StartSecondReparse) - : StartSecondReparse(std::move(StartSecondReparse)) {} + std::atomic<int> Count = {0}; ---------------- sammccall wrote: > ilya-biryukov wrote: > > Maybe use paren initializers? Looks a bit less curly :-) > > ``` > > std::atomic<int> Count(0); > > ``` > This is a member initializer, I think I have to use this syntax :-( You're right, you have to do braced init here. Sorry, my mistake. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43127 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits