Hahnfeld added inline comments.

================
Comment at: test/SemaCUDA/extern-shared.cu:4
+// These declarations are fine in separate compilation mode!
+// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s
+// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -fcuda-rdc -verify=rdc %s
----------------
tra wrote:
> Nit. `-verify=rdc` is somewhat confusing as there's no rdc prefixes in the 
> checks below. Perhaps something along the lines of 
> `-verify=there-should-be-no-errors`  would be more descriptive.
There is: `rdc-no-diagnostics`.

But given that you missed it, maybe I should move the comment `declarations are 
fine` between `RUN` lines and `no-diagnostics`? Don't know if that helps much 
though...


Repository:
  rC Clang

https://reviews.llvm.org/D42923



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to