sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Can you also remove the URI-encoding hack from the VSCode client?



================
Comment at: clangd/Protocol.cpp:35
+    }
+    auto Resolved = URI::resolve(*U);
+    if (!Resolved) {
----------------
I think you can just check that the scheme is file and pull out the path?
we don't want to expose custom URI schemes in LSP, I think


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42419



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to