a.sidorin added a comment.
Hello Adam. I have a nit inline.
================
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1256
+ if (Cond(Reg.second)) {
+ State = setIteratorPosition(State, Reg.first, Proc(Reg.second));
+ }
----------------
Updating ProgramState is usually considered as an expensive operation. Instead,
we can update maps (RegionMap and SymbolMap) and then, if they have any
updates, create a state containing these maps. What do you think?
https://reviews.llvm.org/D32747
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
