EricWF marked 3 inline comments as done.
EricWF added a comment.

@rsmith The trait is already documented in `LanguageExtensions.rst`, so I'll 
assumed you missed that and are not trying to suggest more documentation is 
needed.



================
Comment at: include/clang/Basic/TypeTraits.h:91
+/// \brief Names for the array type traits.
+enum ArrayTypeTrait { ATT_ArrayRank, ATT_ArrayExtent };
 
----------------
rsmith wrote:
> Looks like you reformatted (and reindented) this whole file. If you meant to 
> do that, please commit it as a separate change.
Woops!


================
Comment at: lib/Parse/ParseDeclCXX.cpp:1410
+      Tok.isOneOf(
+          tok::kw___is_abstract, tok::kw___is_aggregate,
+          tok::kw___is_arithmetic, tok::kw___is_array, tok::kw___is_assignable,
----------------
Woops, Clang-format seems to chewed this up. 


https://reviews.llvm.org/D29930



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D29930: A... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D299... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D299... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D299... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D299... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to