It helps to have the first line of the commit message be roughly descriptive, since it forms the brief commit summary in version tools and the subject line in commit email - just "NFC" is a bit unclear. Usually these sort of commits are described as, say "Suppress -Asserts unused-variable warning for variable only used in an assert".
On Fri, Jan 5, 2018 at 4:52 AM Evgeny Stupachenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: evstupac > Date: Thu Jan 4 18:22:52 2018 > New Revision: 321854 > > URL: http://llvm.org/viewvc/llvm-project?rev=321854&view=rev > Log: > NFC. > The patch fixes r321395, that cuased > -Werror=unused-but-set-variable issue for > Diagnosed var on prod build. > > From: Evgeny Stupachenko <evstu...@gmail.com> > > Modified: > cfe/trunk/lib/Serialization/ASTReader.cpp > > Modified: cfe/trunk/lib/Serialization/ASTReader.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Serialization/ASTReader.cpp?rev=321854&r1=321853&r2=321854&view=diff > > ============================================================================== > --- cfe/trunk/lib/Serialization/ASTReader.cpp (original) > +++ cfe/trunk/lib/Serialization/ASTReader.cpp Thu Jan 4 18:22:52 2018 > @@ -10660,6 +10660,7 @@ void ASTReader::diagnoseOdrViolations() > Diagnosed = true; > break; > } > + (void)Diagnosed; > assert(Diagnosed && "Unable to emit ODR diagnostic."); > } > } > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
