rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, looks good other than `ExpressionType`. This is fine to commit with
either of the names I suggested; let me know if you have a better alternative :)
================
Comment at: include/clang/Sema/Sema.h:935-939
+ /// \brief Describes whether we are in an expression that needs
+ /// special handling.
+ enum class ExpressionType {
+ Decltype, TemplateParameter, Other
+ };
----------------
This name is too vague as a member of Sema, but would be OK as a member of
`ExpressionEvaluationContextRecord`, or if renamed to something like
`ExpressionEvaluationContextExprKind`. (Also, we generally use `Kind` rather
than `Type` for situations like this.)
https://reviews.llvm.org/D37442
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
