kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land.
LGTM with a nit ================ Comment at: compiler-rt/lib/hwasan/hwasan.cc:255 -template<bool IsStore, unsigned LogSize> +template<bool Recover, bool IsStore, unsigned LogSize> __attribute__((always_inline, nodebug)) ---------------- I'd prefer enums to booleans, for better readability https://reviews.llvm.org/D41417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
