NoQ added a subscriber: lebedev.ri. NoQ added a comment. @lebedev.ri wrote:
> No tests? This patch adds an assertion => Multiple existing tests immediately starts crashing => This patch fixes the crashes with the new functionality. So in my understanding the new assertion is all the tests we need. Old tests didn't pass when this assertion was enforced, now they do. If somebody breaks the newly added functionality, the regression will immediately show up on tests by hitting the assertion. Additionally, i'm adding actual practical tests (of how the analyzer's behavior actually change) in a follow-up patch (https://reviews.llvm.org/D41250). So if we merge these two patches (if necessary), we'd have new stuff in the tests directory. Or i could try to come up with actual tests for this patch, but i'm not sure it's worth it given the above. Please correct me if my logic is flawed or contradicts existing policies. https://reviews.llvm.org/D40939 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
