rnk added inline comments.
================
Comment at: lib/CodeGen/CodeGenModule.cpp:690-692
+  // Only handle ELF for now.
+  if (!CGM.getTriple().isOSBinFormatELF())
+    return false;
----------------
Handling COFF here is probably trivial. Everything is dso_local unless it's 
dllimport. Does that matter, or is dso_local intended to be an ELF-specific 
annotation?


https://reviews.llvm.org/D41318



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D41318... Rafael Ávila de Espíndola via Phabricator via cfe-commits
    • [PATCH] D... Reid Kleckner via Phabricator via cfe-commits
      • Re: [... Rafael Avila de Espindola via cfe-commits
        • R... Rafael Avila de Espindola via cfe-commits
    • [PATCH] D... Reid Kleckner via Phabricator via cfe-commits
    • [PATCH] D... Rafael Avila de Espindola via Phabricator via cfe-commits

Reply via email to