nathawes marked 45 inline comments as done.
nathawes added inline comments.
================
Comment at: lib/Index/FileIndexRecord.h:51
+public:
+ FileIndexRecord(FileID FID, bool isSystem) : FID(FID), IsSystem(isSystem) {}
+
----------------
ioeric wrote:
> s/isSystem/IsSystem/
>
> Also, I wonder if we can filter out system decls proactively and avoid
> creating file index record for them. We could also avoid propogating
> `IsSystem` here.
If the -index-ignore-system-symbols flag is set system decls are filtered out
in IndexingContext::handleDeclOccurrence and aren't reported to the
IndexDataConsumer, so FileIndexRecords won't be created. The IsSystem here is
for clients that want index data for system files, but want to be able to
distinguish them from regular files.
https://reviews.llvm.org/D39050
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
